Submitted by Wayne, also found by hyh, PPrieditis, rayn, smilingheretic, and Cr4ckM3_
yVault.sol#L61
yVaultLPFarming.sol#L54
The expectation of the noContract modifier is to allow access only to accounts inside EOA or Whitelist, if access is controlled using ! access control with _account.isContract(), then because isContract() gets the size of the code length of the account in question by relying on extcodesize/address.code.length, this means that the restriction can be bypassed when deploying a smart contract through the smart contracts constructor call.
Modify the code to require(msg.sender == tx.origin);
spaghettieth (JPEGd) confirmed, but disagreed with Medium severity and commented:
spaghettieth (JPEGd) resolved and commented:
LSDan (judge) commented:
