Submitted by WatchPug
NFTLoanFacilitator.sol#L102-L102
NFTLoanTicket.sol#L33-L35
If mintBorrowTicketTo is a contract that does not implement the onERC721Received method, in the current implementation of createLoan(), the tx will still be successfully, and the loan will be created.
This can be a problem if mintBorrowTicketTo can not handle ERC721 properly, as the BorrowTicket NFT will be used later to get back the users funds.
Consider using safeMint in NFTLoanTicket.sol#mint():
wilsoncusack (Backed Protocol) acknowledged, but disagreed with Medium severity and commented:
gzeon (judge) commented:
wilsoncusack (Backed Protocol) commented:
gzeon (judge) commented:
wilsoncusack (Backed Protocol) commented:
For this contest, 34 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by warden IllIllI received the top score from the judge.
The following wardens also submitted reports: Dravee, shenwilly, teryanarmen, hake, reassor, TerrierLover, 0xDjango, m9800, robee, securerodd, t11s, tintin, 0v3rf10w, 0xkatana, berndartmueller, BouSalman, CertoraInc, FSchmoede, rayn, Ruhum, sorrynotsorry, VAD37, PPrieditis, 0x1f8b, csanuragjain, Hawkeye, horsefacts, hubble, Kenshin, Meta0xNull, samruna, WatchPug, and z3s.
