Submitted by cmichel, also found by teryanarmen
NFTLoanFacilitator.sol#L309
Admins can update the origination fee by calling updateOriginationFeeRate.
Note that a borrower does not receive their minLoanAmount set in createLoan, they only receive (1 - originationFee) * minLoanAmount, see lend.
Therefore, they need to precalculate the minLoanAmount using the current origination fee to arrive at the post-fee amount that they actually receive.
If admins then increase the fee, the borrower receives fewer funds than required to cover their rent and might become homeless.
Reconsider how the min loan amount works. Imo, this minLoanAmount should be the post-fee amount, not the pre-fee amount. Its also more intuitive for the borrower when creating the loan.
wilsoncusack (Backed Protocol) disputed and commented:
wilsoncusack (Backed Protocol) acknowledged, but disagreed with Medium severity and commented:
wilsoncusack (Backed Protocol) resolved and commented:
gzeon (judge) commented:
