Submitted by 0x52
TopUpAction.sol#L154
TopUpAction.sol#L187
The default swap slippage of 5% allows malicious keepers to sandwich attack topup. Additionally, up to 40% (_MINSWAPPERSLIPPAGE) slippage allows malicious owner to sandwich huge amounts from topup
Keeper can bundle swaps before and after topup to sandwich topup action, in fact its actually in their best interest to do so.
Allow user to specify max swap slippage when creating topup similar to how its specified on uniswap or sushiswap to block attacks from both keepers and owners.
chase-manning (Backd) confirmed and resolved
gzeon (judge) commented:
