Submitted by hubble
HolyPaladinToken.sol#L446-L468
When the contract is in blocked state (emergency mode), the protocol wants to return an empty UserLock info, on calling the function getUserLock.
However, there is another way, by which the users can find the same information.
The below function is not protected when in emergency mode, and users can use this alternatively.
Line#466 function getUserPastLock(address user, uint256 blockNumber)
There is no loss of funds, however the intention to block information (return empty lock info) is defeated, because not all functions are protected.
There is inconsistency in implementing the emergency mode check.
Contract Name : HolyPaladinToken.sol
Functions getUserLock and getUserPastLock
Add checking for emergency mode for this function getUserPastLock.
Additional user access check can be added, so that the function returns correct value when the caller(msg.sender) is admin or owner.
Kogaroshi (Paladin) confirmed, resolved, and commented:
