Submitted by GeekyLumberjack, also found by CertoraInc
LibSwap.sol#L42-L46
swap is used throughout the code via _executeSwaps in Swapper.sol. According to Solidity Docs the call may return true even if it was a failure. This may result in user funds lost because funds were transferred into this contract in preparation for the swap. The swap fails but doesnt revert. There is a way this can happen through GenericSwapFacet.sol due to a missing require that is present in the other facets which is a separate issue but gives this issue more relevance.
Check for contract existence.
A similar issue was awarded a medium here.
H3xept (Li.Fi) resolved
gzeon (judge) commented:
