Submitted by hickuphh3, also found by 0xDjango, catchup, csanuragjain, hyh, shw, WatchPug, and ych18
DexManagerFacet.sol#L71-L73
The function intends to allow the removal of multiple dexes approved for swaps. However, the function will only remove the first DEX because return is used instead of break in the inner for loop.
This error is likely to have gone unnoticed because no event is emitted when a DEX is added or removed.
Add the following lines below L44 of [AnyswapFacet.test.ts](https://github.com/code-423n4/2022-03-lifinance/blob/main/test/facets/AnyswapFacet.test.ts#L44)
Replace return with break.
In addition, it is recommend to emit an event whenever a DEX is added or removed.
H3xept (Li.Fi) resolved and commented:
gzeon (judge) commented:
