Submitted by hubble
https://github.com/code-423n4/2022-03-joyn/blob/c9297ccd925ebb2c44dbc6eaa3effd8db5d2368a/core-contracts/contracts/CoreCollection.sol#L175-L176
https://github.com/code-423n4/2022-03-joyn/blob/c9297ccd925ebb2c44dbc6eaa3effd8db5d2368a/core-contracts/contracts/ERC721Payable.sol#L54-L55
The below transferFrom command is called at two places in the core contracts, followed by an emit event
The return value is not checked during the payableToken.transferFrom
In the event of failure of payableToken.transferFrom(), the emit event is still generated causing the downstream applications to capture
wrong transaction / state of the protocol.
Add a require statement as being used in the RoyaltyVault.sol
sofianeOuafir (Joyn) confirmed, disagreed with severity and commented:
deluca-mike (judge) commented:
