Submitted by hickuphh3, also found by 0x
https://github.com/code-423n4/2022-03-joyn/blob/main/splits/contracts/Splitter.sol#L14
https://github.com/code-423n4/2022-03-joyn/blob/main/splits/contracts/Splitter.sol#L103
There is a PERCENTAGE_SCALE = 10e5 defined, but the actual denominator used is 10000. This is aggravated by the following factors:
Thus, if an incorrect denominator is used, the calculated claimable amount could exceed the actual available funds in the contract, causing claims to fail and funds to be permanently locked.
Remove PERCENTAGE_SCALE because it is unused, or replace its value with 10_000 and use that instead.
P.S: there is an issue with the example scaled percentage given for platform fees (5% = 200). Should be 500 instead of 200.
sofianeOuafir (Joyn) confirmed and commented:
