Submitted by cmichel
The BribeVault.transferBribes transfers tokens for distribution.
All parameters (amounts, distributions) are blindly accepted by the function and never verified to match the actual bribes that were deposited for the distributions[i].rewardIdentifier.
The distributions[i].token must not match the distributions[i].rewardIdentifiers token (included in the reward identifier hash), and the amounts[i] (and fees) must not match the bribes[bribeIdentifier].amount.
The admin can submit arbitrary values and create distributions that dont reflect the bribe the distribution is actually for.
Its easy to under-or overreport amounts for a bribe, take amounts from a different bribe, or steal all amounts from users by using 100% fees, distribute the same bribe over and over, etc.
Reduce the trust that users need to have in the admin by validating the Common.Distribution[] calldata distributions,  uint256[] calldata amounts, uint256[] calldata fees parameters against the deposited bribes.
For example:
kphed (Redacted Cartel) disagreed with High severity and commented:
Alex the Entreprenerd (judge) decreased severity to Medium and commented:
