Submitted by kirk-baird, also found by cmichel and Omik
PermitAndMulticall.sol#L46-L64
PermitAndMulticall.sol#L31-L37
TWABDelegator.sol#L438-L445
When the _from address is not the msg.sender _multiCall() will be made on behalf of the msg.sender. As a result each of the functions called by multiCall() will be made on behalf of msg.sender and not _from.
If functions such as transfer() or unstake() are called msg.sender will be the original caller which would transfer the attacker the funds if the to field is set to an attackers address.
Furthermore, if an attacker we to call permitAndMulticall() before the _from user they may use their signature and nonce combination. As a nonce is only allowe to be used once the siganture will no longer be valid and _permitToken.permit() will fail on the second call.
An attacker may use this as a Denial of Service (DoS) attack by continually front-running permitAndCall() using other users signatures.
Consider updating the _from field to be the msg.sender in permitAndMulticall() (or alternatively do this in _permitAndMulticall() to save some gas).
PierrickGT (PoolTogether) confirmed and resolved:
PierrickGT (PoolTogether) disagreed with Medium severity and commented:
0xleastwood (judge) commented:
PierrickGT (PoolTogether) commented:
0xleastwood (judge) commented:
For this contest, 9 reports were submitted by wardens detailing low risk and non-critical issues. The reports highlighted below received the top 3 scores from the judge and are by the following wardens/teams: 1) WatchPug; 2) CertoraInc; and 3) hickuphh3.
The following wardens also submitted reports: gzeon, Rhynorater, Dravee, chunter, jayjonah8, and robee.
