Submitted by gzeon
Upgradable escrow contract poses great risk to user who approved their NFT to the contract. Most popular token / NFT exchange do not require user to approve their asset to admin upgradable contract.
This also increases user gas usage because they would have to revoke approval when they are done with the protocol.
https://github.com/code-423n4/2022-02-foundation/blob/4d8c8931baffae31c7506872bf1100e1598f2754/contracts/FNDNFTMarket.sol
Separate the escrow contract to make it non-upgradable with a restricted set of functionality.
NickCuso (Foundation) acknowledged and commented:
