Submitted by cmichel
NFTMarketPrivateSale.sol#L156
Similar to spoofing in finance, users can create private sales with correct signatures but then frontrun the buy with a transfer to a different wallet they control.
No funds are lost as the NFT <> FETH exchange is atomic but it can be bad if third parties create a naive off-chain centralized NFT market based on this signature feature.
Its also frustrating for the users if they try to accept the private sale but their transaction fails.
This is made possible because private sales do not keep the NFT in escrow.
Consider escrowing the NFT also for private sales.
NickCuso (Foundation) acknowledged and commented:
