Submitted by WatchPug, also found by hickuphh3 and leastwood
According to:
MasterChef is only recording the deposited amount in the states, its not actually holding the depositToken.
depositToken wont be transferred from _msgSender() to the MasterChef contract.
Therefore, in updatePool() L140 lpSupply = pool.depositToken.balanceOf(address(this)) will always be 0. And the updatePool() will be returned at L147.
MasterChef.sol#L135-L154
Consider creating a receipt token to represent the invested token and use the receipt tokens in MasterChef.
See: https://github.com/convex-eth/platform/blob/883ffd4ebcaee12e64d18f75bdfe404bcd900616/contracts/contracts/Booster.sol#L272-L277
ryuheimat (Concur) confirmed
Alex the Entreprenerd (judge) commented:
