Submitted by hickuphh3, also found by leastwood
MasterChef.sol#L170-L172
If a pools deposit fee is non-zero, it is subtracted from the amount to be credited to the user.
However, the deposit fee is not credited to anyone, leading to permanent lockups of deposit fees in the relevant depositor contracts (StakingRewards and ConvexStakingWrapper for now).
Assume the following
These examples are non-exhaustive as more depositors can be added / removed from the Masterchef contract.
I recommend shifting the deposit fee logic out of the masterchef contract into the depositor contracts themselves, as additional logic would have to be added in the masterchef to update the fee recipients state (rewardDebt, send pending concur rewards, update amount), which further complicates matters. As the fee recipient is likely to be the treasury, it is also not desirable for it to accrue concur rewards.
ryuheimat (Concur) confirmed
Alex the Entreprenerd (judge) commented:
