Submitted by WatchPug
https://github.com/code-423n4/2021-11-unlock/blob/ec41eada1dd116bcccc5603ce342257584bec783/smart-contracts/contracts/mixins/MixinTransfer.sol#L131-L152
Based on the context, L131-136 seems to be the logic of handling the case of the recipient with no key, and L138-148 is handing the case of the recipients key expired.
However, in L131-136, the key manager is not being reset.
This allows attackers to keep the role of key manager after the transfer, and transfer the key back or to another recipient.
Given:
Consider resetting the key manager regardless of the status of the recipients key.
julien51 (Unlock Protocol) confirmed:
0xleastwood (judge) commented:
julien51 (Unlock Protocol) confirmed:
