Submitted by palina
The reserve address variable in NestedFactory.sol remains equal to 0 before the setReserve() function is called by an owner. This may lead to incorrect transfers of tokens or invalid comparison with e.g., the asset reserve (nestedRecords.getAssetReserve(_nftId) == address(reserve)), should they occur before the value for reserve was set.
In addition, the immutabiliy of the reserve variable requires extra caution when setting the value.
setReserve(): NestedFactory.sol L89
Manual Analysis
Consider initializing the value for the reserve variable in the constructor.
maximebrugel (Nested) commented:
alcueca (judge) commented:
