Submitted by jayjonah8
In the AuctionEscapeHatch.sol file both earlyExitReturn() and \_calculateMaltRequiredForExit call the getAuctionCore() function which has 10 possible return values most of which are not used.  It gets the wrong value back for the active  variable since its the 10th argument but both functions have it as the 9th return value where preAuctionReserveRatio should be because of one missing comma.  This is serious because these both are functions which deal with allowing a user to exit their arbitrage token position early.  This can result in a loss of user funds.
Manual code review
In AuctionEscapeHatch.sol change the following in \_calculateMaltRequiredForExit() and earlyExitReturn() functions:
From:
(,,,,,
uint256 pegPrice,
,
uint256 auctionEndTime,
bool active
) = auction.getAuctionCore(_auctionId);
To:
(,,,,,
uint256 pegPrice,
,
uint256 auctionEndTime,
,
bool active
) = auction.getAuctionCore(_auctionId);
0xScotch (sponsor) confirmed
Alex the Entreprenerd (judge) commented:
