Submitted by 0xRajeev
The manager.allowedVaults check is missing for add/remove strategy like how it is used in reorderStrategies(). This will allow a strategist to accidentally/maliciously add/remove strategies on unauthorized vaults.
Given the critical access control that is missing on vaults here, this is classified as medium severity.
Manual Analysis
Add manager.allowedVaults check in addStrategy() and removeStrategy()
GainsGoblin (yAxis) acknowledged
Haz077 (yAxis) confirmed
uN2RVw5q commented:
GalloDaSballo (judge) commented:
