Submitted by jonah1005
Theres no safety check in Manager.sols removeToken. Manager.sol#L454-L487
Calling removeToken way would almost break the whole protocol if the vault has already started. I consider this is a high-risk issue.
We can see how the vault would be affected with below web3.py script.
output
Hardhat
Remove tokens from a vault would be a really critical job. I recommend the team cover all possible cases and check all components states (all vault/ strategy/ controllers state) in the test.
Some steps that I try to come up with that is required to remove TokenA from a vault.
transferAndCall (yAxis) acknowledged:
transferAndCall (yAxis) confirmed and patched:
GalloDaSballo (judge) commented:
