The distribute function can be re-entered by fake tokens or tokens with callbacks.
An attacker can use the callbacks on safeTransfer if a token has a callback to reenter an drain the entire balance of that particular token before the notifyRewardAmount is called.
I think this is only a medium issue because the attacker can only take tokens with callbacks, and I dont think any of the tokens you guys use have callbacks.
CvxStakingProxy.sol L153
Be aware of this possibility. If you really want to, add a nonReentrant modifier to the function.
GalloDaSballo (BadgerDAO) acknowledged:
ghoul-sol (judge) commented:
