Submitted by leastwood
The circuitBreaker() function in RCMarket.sol is utilised in the event an oracle never provides a response to a RealityCards question. The function makes an external call to the RCOrderbook.sol contract through the closeMarket() function. If for some reason the orderbook was unable to be closed, this would never be checked in the circuitBreaker() function. See RCMarket.sol L1215-L1223.
Recommend ensuring this is intended behavior, or otherwise validate the response of orderbook.closeMarket(). Another option would be to emit the result of the external call in the LogStateChange event, alongside the state change.
Splidge (Reality Cards) confirmed:
Splidge (Reality Cards) patched:
