Submitted by cmichel
The nTokenERC20Proxy functions emit events all the time, even if the return value from the inner call returns false, indicating an unsuccessful action.
An off-chain script scanning for Transfer or Approval events can be tricked into believing that an unsuccessful transfer was indeed successful.
This happens in the approve, transfer and transferFrom functions.
Recommend only emitting events on success.
jeffywu (Notional) confirmed
