Submitted by gpersoon
The function getRouterImplementation of Router.sol checks the selectors of functions and calls the appropriate function.
Selectors are only 4 bytes long, so there is a theoretical probability of a collision (e.g. two functions having the same selector).
This is comparable to the birthday attack.
The probability of a collision when you have 93 different functions is 10^6.
Due to the structure of the Router.sol, the solidity compiler does not prevent collisions
Recommend double checking (perhaps via a continuous integration script / github workflow), that there are no collisions of the selectors.
- jeffywu (Notional) confirmed
