Submitted by hickuphh3
Updating a kValue of a market requires interpolation against the initial timestamp, which can be a hassle and might lead to a wrong value set from what is expected.
Consider the following scenario:
In the current implementation, the admin would call _changeMarketLaunchIncentiveParameters() with the following inputs:
This isnt immediately intuitive and could lead to mistakes.
Recommend that Instead of calculating from initialTimestamp (when addNewStakingFund() was called), calculate from when the market incentives were last updated. This would require a new mapping to store last updated timestamps of market incentives.
For example, using the scenario above, refreshing the market incentive would mean using inputs period = 2592000 (30 days) with kValue = 2e18.
JasoonS (Float) confirmed:
