Submitted by gpersoon, also found by hickuphh3
If the payment token would be an ERC777 token (or another token that has callbacks), then an reentrancy attack could be tried.
Especially in function_executeOutstandingNextPriceSettlements multiple transfers are called, which could call callbacks.
These callbacks could go to an attacker contract which could call functions of the LongShort.sol contract
Although I havent found a scenario to misuse the reentrancy its better to prevent this.
LongShort.sol #L1035
Recommend preventing reentrancy attacks in one of the following ways:
JasoonS (Float) disputed:
0xean (judge) commented:
