Submitted by gpersoon
When the DAO is upgraded via moveDao, it also updates the DAO address in BASE. However it doesnt update the DAO address in the Reserve.sol contract. This could be done with the function setIncentiveAddresses(..)
Now the next time grantFunds of DAO.sol is called, its tries to call _RESERVE.grantFunds(...)
The grantFunds of Reserve.sol has the modifier onlyGrantor(), which checks the msg.sender == DAO.
However in the mean time, the DAO has been updated and Reserve.sol doesnt know about it and thus the modifier will not allow access to the function. Thus grantFunds will revert.
Dao.sol L452
Reserve.sol L17
Recommend calling setIncentiveAddresses(..) when a DAO upgrade is done.
verifyfirst (Spartan) confirmed:
