Submitted by shw, also found by 0xRajeev
The claimAllForMember function of Dao is permissionless, allowing anyone to claim the unlocked bonded LP tokens for any member. However, claiming a members LP tokens could decrease the members weight in the BondVault, thus affecting the members votes and rewards in the Dao contract.
For example, an attacker can intentionally front-run a victims voteProposal call to decrease the victims vote weight to prevent the proposal from being finalized:
Similarly, an attacker can front-run a victims harvest call to intentionally decrease the victims reward since the amount of reward is calculated based on the victims current weight.
See issue page page for referenced code
Consider removing the member parameter in the claimAllForMember function and replace all member to msg.sender to allow only the user himself to claim unlocked bonded LP tokens.
verifyfirst (Spartan) confirmed and disagreed with severity:
ghoul-sol (judge) commented:
