zapLiquidity() used to trade LP tokens of one pool to another is missing a check for toPool != fromPool which may happen accidentally. The check will prevent unnecessary transfers and avoid any fees/slippage or accounting errors.
Recommend adding toPool != fromPool as part of input validation.
verifyfirst (Spartan) confirmed:
