Submitted by gpersoon, also found by pauliax
The function initialize of SwappableYieldSource checks that the yield source is valid via _requireYieldSource.
When you change the yield source (via swapYieldSource or setYieldSource), then the function _setYieldSource is called.
However _setYieldSource  doesnt explicitly check the yield source via _requireYieldSource.
The risk is low because there is an indirect check, by the following check, which only succeeds is depositToken is present in the new yield source:
For maintenance purposes it is more logical to always call _requireYieldSource, especially if the check would be made more extensive in the future.
Recommend adding the following statement to _setYieldSource:
PierrickGT (PoolTogether) disputed:
0xean (Judge) commented:
PierrickGT (PoolTogether) commented:
