Submitted by GalloDaSballo
SwappableYieldSource.sol L74 runs a few checks to see if the function depositToken is implemented.
Notice that this is not a guarantee that the target is a valid Yield Source.
This will simply verify that the contract has that method.
Any malicious attacker could implement that function and then set up the Yield Source to steal funds
In order to guarantee that the target is a valid Yield Source, youd want to create a registry of know Yield Sources, perhaps controlled by governance or by the DAO, and check against that.
Recommend either:
PierrickGT (PoolTogether) disputed
PierrickGT (PoolTogether) commented:
0xean (Judge) commented:
PierrickGT (PoolTogether) commented:
