Submitted by hickuphh3, also found by 0xRajeev
transferFunds() will transfer funds from a specified yield source _yieldSource to the current yield source set in the contract _currentYieldSource. However, it fails to check that the deposit tokens are the same. If the specified yield sources assets are of a higher valuation, then a malicious owner or asset manager will be able to exploit and pocket the difference.
Assumptions:
Attacker does the following:
_requireDifferentYieldSource() should also verify that the yield sources deposit token addresses are the same.
PierrickGT (PoolTogether) acknowledged:
0xean (Judge) commented:
