Submitted by cmichel, also found by hickuphh3, pauliax and jonah1005XXX
The SwappableYieldSource.redeemToken function transfers tokens from the contract back to the sender, however, it uses the ERC20.transferFrom(address(this), msg.sender, redeemableBalance) function for this.
Some deposit token implementations might fail as transferFrom checks if the contract approved itself for the redeemableBalance instead of skipping the allowance check in case the sender is the from address.
This can make the transaction revert and the deposited funds will be unrecoverable for the user.
Its recommended to use _depositToken.safeTransfer(msg.sender, redeemableBalance) instead.
PierrickGT (PoolTogether) commented:
0xean (Judge) commented:
PierrickGT (PoolTogether) resolved:
