Submitted by shw, also found by 0xRajeev
As written in the to-do comments, reentrancy could happen in the executeTrade function of Trader since the makeOrder.market can be a user-controlled external contract. See L121-L126 in Trader.sol.
Recommend adding a reentrancy guard (e.g., the implementation from OpenZeppelin) to prevent the users from reentering critical functions.
raymogg (Tracer) disputed:
cemozerr (Judge) commented:
OsmanBran (Tracer) commented:
