Submitted by 0xRajeev
The exitedTimestamp flag is used to prevent front-running of user exiting and re-entering in the same block. The setting of this flag in exit() should really be inside the conditionals and triggered only if current owner or if bidExists. It currently assumes that either of the two will always be true which may not necessarily be the case.
The impact of this is that a user accidentally exiting a card he doesnt own or have a bid for currently, will be marked as exited and prevented from a newRental in the same block. User can prevent ones own newRental from succeeding, because it was accidentally triggered, by front-running it himself with an exit. There could be other more realistic scenarios.
Recommend setting exitedTimestamp flag only when the conditionals are true within exit()
Splidge (Reality Cards) confirmed and resolved:
