Submitted by 0xRajeev
Missing _checkState(States.OPEN) on first line of rentAllCards() as specified on L617. These core market functions are supposed to operate only when market is open but the missing check allows control to proceed further in the control flow. In this case, the function proceeds to call newRental() which has a conditional check state == States.OPEN and silently returns success otherwise, without reverting.
The impact of this is that rentAllCards does not fail if executed when market is closed or locked. newRental returns silently without failure when market is closed or locked.
Add a require() to check market open state in the beginning of all core market functions and revert with an informative error string otherwise.
Splidge (Reality Cards) confirmed and resolved:
