Submitted by 0xRajeev
The _depositInVault() returns the value returned from its call to the Yearn vaults deposit() function. However, the return value is ignored at both call sites in supplyTokenTo() and sponsor().
 It is unclear what the intended usage is and how, if any, the return value should be checked. This should perhaps check how much of the full balance was indeed deposited/rejected in the vault by comparing the return value of issued vault shares as commented: The actual amount of shares that were received for the deposited tokens because if deposit limit is reached, tokens will remain in the Yield Source and they will be queued for retries in subsequent deposits.
Recommend checking return value appropriately or if not, document why this is not necessary.
asselstine (PoolTogether) disputed:
dmvt (judge) commented:
