Submitted by 0xRajeev
Token amounts/prices are typically open-ranged and inclusive of the bounds. Using < or > instead of <= and >= may affect borderline scenarios, be considered unintuitive by users, and affect accounting.
-Scenario 1: In calculateVaultSwapData(), the require() check is:
The < could be replaced by <=
Scenario 2: In withdrawSingleByLiquidity(), the require() check is:
The > should be >= as is used in the similar check in withdrawSingleByExchange().
See Insurance.sol L429, and LifeGuard3Pool.sol L224 and L268.
Recommend reconsidering strict inequalities and relaxing them if possible.
kristian-gro (Gro) acknowledged:
