The NFTXVaultUpgradeable.flashLoan is not correctly implemented according to  EIP-3156 (but it tries to implement it as it inherits from IERC3156FlashLenderUpgradeable).
It misses the return and currently always returns false.
Always returning false indicates that the flash loan was unsuccessful, when in reality it could have been successful.
This breaks any contract trying to integrate with it.
Recommend adding the return statement: return super.flashLoan(...)
- 0xKiwi (NFTX) confirmed
- cemozer (Judge) commented:
