There are two issues with the governance checks when acquiring them from an NFT:
The governance checks in _updateConvictionScore are:
Whereas in acquireConviction, only userConvictionScore >= governanceThreshold is checked but not && balanceOf(user) >= governanceMinimumBalance.
The second issue is that at the time of NFT creation, the governanceThreshold or governanceMinimumBalance was different and would not qualify for a governor now.
The NFTs governance state is blindly appplied to the new user:
This allows a user to circumvent any governance parameter changes by front-running the change with an NFT creation. Its easy to circumvent the balance check to become a governor by minting and redeeming your own NFT. One can also circumvent any governance parameter increases by front-running these actions with an NFT creation and then backrunning with a redemption.
Recommend adding the missing balance check-in acquireConviction, removing the wasGovernance governance transfer from the NFT, and recomputing it based solely on the current governanceThreshold / governanceMinimumBalance settings.
fairside-core (FairSide) confirmed:
fairside-core (FairSide) resolved:
