The credit score of the special address(type(uint160).max) is supposed to represent the sum of the credit scores of all users that are governors.
But, any user can directly transfer to this address, increasing its balance and accumulating a credit score in _updateConvictionScore(to=address(uint160.max), amount).
Itll first write a snapshot of this address balance, which should be very low:
This address then accumulates a score based on its balance, which can be updated using updateConvictionScore(uint160.max) and breaks the invariant.
Increasing it might be useful for non-governors that dont pass the voting threshold and want to grief the proposal voting system by increasing the quorumVotes threshold required for proposals to pass. By manipulating FairSideDAO.totalVotes, totalVotes can be arbitrarily inflated and break the voting mechanism as no proposals can reach the quorum (percentage of totalVotes) anymore.
Recommend disallowing transfers from/to this address. Or better, track the total governance credit score in a separate variable, not in an address.
fairside-core (FairSide) confirmed:
fairside-core (FairSide) resolved:
cemozerr (Judge) commented:
