A variable named fairSideConviction is set in the contract FSD function setFairSideConviction. However, functions that use this variable do not check that it is already initialized. For example, function tokenizeConviction in contract ERC20ConvictionScore may transfer tokens to the 0x0 address:
This will make these tokens inaccessible and basically burned. It would be better if the code explicitly checked before that address(fairSideConviction) != address(0)
Rating this as low because I expect that, in practice, these variables will be initialized as soon as possible.
Also, this may be an additional small issue. Still, I think it would make sense if functions setFairSideConviction and setFairSideNetwork explicitly check that the parameter is not 0x0 address as it is theoretically possible to invoke these functions again and again when the address is empty.
Recommend requiring address(fairSideConviction) != address(0) where this variable is used. Same can be applied to fsdNetwork variable.
fairside-core (FairSide) acknowledged:
cemozerr (Judge) commented:
