In ERC20ConvictionScore._updateConvictionScore, when the user does not fulfill the governance criteria anymore, the governanceDelta is the old conviction score of the previous block.
The user could increase their conviction/governance score first (in the same block) and then lose their status in a second transaction. After which, the total governance conviction score would only be reduced by the previous score.
** Example:**
Block n - 10000: User is a governor and has a credit score of 1000, which was also contributed to the TOTAL_GOVERNANCE_SCORE
Block n:
In this way, the TOTAL_GOVERNANCE_SCORE score can be inflated and, in the worst case, break the voting mechanism, as no proposals can reach the quorum (percentage of totalVotes) anymore.
Recommend using the current conviction store which should be governanceDelta = checkpoints[user][userCheckpointsLength - 1].convictionScore.
fairside-core (FairSide) confirmed but disagreed with severity:
fairside-core (FairSide) disputed:
fairside-core (FairSide) re-confirmed:
cemozerr (Judge) commented:
