The TOTAL_GOVERNANCE_SCORE is supposed to track the sum of the credit scores of all governors.
In ERC20ConvictionScore._updateConvictionScore, when the user does not fulfill the governance criteria anymore and is therefore removed, the governanceDelta should be negative, but its positive.
It then gets added to the new total:
The TOTAL_GOVERNANCE_SCORE tracks wrong data leading to issues throughout all contracts like wrong FairSideDAO.totalVotes data, which can then be used by anyone to pass proposals in the worst case.
Or totalVotes can be arbitrarily inflated and break the voting mechanism as no proposals can reach the quorum (percentage of totalVotes) anymore.
Recommend returning a negative signed integer for this case and adding it to the new total.
fairside-core (FairSide) confirmed:
