The DInterest.deposit function takes a depositAmount parameter but this parameter is not the actual transferred amount for fee-on-transfer / deflationary (or other rebasing) tokens.
The actual deposited amount might be lower than the specified depositAmount of the function parameter.
This would lead to wrong interest rate calculations on the principal.
Recommend transferring the tokens first and comparing pre-/after token balances to compute the actual deposited amount.
ZeframLou (88mph) acknowledged:
