The deploySynth() function in Pools.sol is expected to perform a check on the token parameter to determine that it is neither VADER or USDV before calling Factorys deploySynth() function.
However, the require() incorrectly uses the || operator instead of && which allows both VADER and USDV to be supplied as the token parameters. This will allow an attacker to deploy either VADER or USDV as a Synth which will break assumptions throughout the entire protocol. Protocol will break and funds may be lost.
Recommend changing || operator to && in the require statement:
require(token != VADER && token != USDV);
strictly-scarce (vader) addressed:
0xBrian commented:
