Submitted by berndartmueller, also found by R2, minhquanym, Jeiwan, ayeslick, and 0xdeadbeef0x
A credit line can be closed by using the LineOfCredit.depositAndClose() or LineOfCredit.close. The remaining funds deposited by the lender (credit.deposit) and the accumulated and paid interest are transferred to the lender.
However, if the used credit token credit.token is native ETH (or an ERC-777 token with receiver hooks, and under the assumption that the oracle supports this asset in the first place), the lender can reject the closing of the credit by reverting the token transfer.
The lender can prevent the borrower from closing the credit line. This leads to the following consequences:
modules/credit/LineOfCredit.sol#L489-L493
Consider using a pull-based pattern to allow the lender to withdraw the funds instead of sending them back directly.
kibagateaux (Debt DAO) confirmed
For this contest, 78 reports were submitted by wardens detailing low risk and non-critical issues. The report highlighted below by IllIllI received the top score from the judge.
The following wardens also submitted reports: ajtra,
brgltd,
pashov,
rbserver,
c3phas,
0xNazgul,
Awesome,
immeas,
jumpdest7d,
Deivitto,
rotcivegaf,
lukris02,
joestakey,
Josiah,
djxploit,
0xSmartContract,
Trust,
pedr02b2,
B2,
Aymen0909,
RedOneN,
cryptostellar5,
Diana,
Funen,
bulej93,
cryptonue,
a12jmx,
delfin454000,
ctf_sec,
__141345__,
minhquanym,
adriro,
erictee,
TomJ,
zaskoh,
peanuts,
merlin,
btk,
seyni,
ReyAdmirado,
0x1f8b,
saneryee,
slowmoses,
shark,
HardlyCodeMan,
apostle0x01,
tnevler,
BClabs,
carlitox477,
Rahoz,
sakman,
gogo,
0xRoxas,
catwhiskeys,
durianSausage,
csanuragjain,
fatherOfBlocks,
trustindistrust,
Deekshith99,
w0Lfrum,
aphak5010,
Saintcode_,
Nyx,
oyc_109,
i_got_hacked,
ch0bu,
rvierdiiev,
Bnke0x0,
Rolezn,
chrisdior4,
mcwildy,
HE1M,
chaduke,
martin,
Dinesh11G,
yurahod, and
RaymondFam.
