Submitted by catchup
ConvexMasterChef.sol#L178-L183
massUpdatePools() is a public function and it calls the updatePool() function for the length of poolInfo. Hence, it is an unbounded loop, depending on the length of poolInfo.
If poolInfo.length is big enough, block gas limit may be hit.
https://consensys.github.io/smart-contract-best-practices/attacks/denial-of-service/#dos-with-block-gas-limit
I suggest to limit the max number of loop iterations to prevent hitting block gas limit.
0xMaharishi (Aura Finance) disagreed with severity and commented:
LSDan (judge) commented:
IllIllI000 (warden) commented:
dmitriia (warden) commented:
LSDan (judge) commented:
0xMaharishi (Aura Finance) confirmed and resolved
