Submitted by evan
The yIntercept of a public vault can overflow due to an unchecked addition. As a result, totalAsset will be a lot lower than the actual amount, which prevents liquidity providers from withdrawing a large fraction of their assets.
https://github.com/code-423n4/2023-01-astaria/blob/main/src/PublicVault.sol#L323-L325
The amount of assets required for this to happen is barely feasible for a regular 18 decimal ERC20 token, but can happen with ease for tokens with higher precision.
VSCode, Foundry
Remove the unchecked block.
