Submitted by WatchPug, also found by CertoraInc and hickuphh3
NFTLoanFacilitator.sol#L167-L179
The requiredImprovementRate represents the percentage of improvement required of at least one of the terms when buying out from a previous lender.
However, when previousInterestRate is less than 10 and requiredImprovementRate is 100, due to precision loss, the new interestRate is allowed to be the same as the previous one.
Making such an expected constraint absent.
Charlie is expected to provide at least 10% better terms, but actually bought out Bob with the same terms.
Consider using: OpenZeppelin/Math.sol#L39-L42
And change the check to:
wilsoncusack (Backed Protocol) confirmed and resolved
gzeon (judge) commented:
