Submitted by tensors
Some of the actions in TradingAction.sol can be front-run. Since there are no slippage protections, its unclear how bad this problem can be.
See TradingAction.sol L334.
An example is _settleCashDebt(). This goes through _getfCashSettleAmount() which uses an impliedRate variable. This can be manipulated by a frontrunner. Add checks that exist on the other trade types.
Recommend adding minAmountOut/minAmountCredited as function variables to protect against frontrunning. For example. _executeLiquidityTrade has such protections in place.
T-Woodward (Notional) acknowledged but disagreed with severity:
jeffywu (Notional) commented:
ghoul-sol (judge) commented:
