Submitted by gpersoon
In the function findNewOwner of RCOrderbook, as loop is done which included the check  _loopCounter < maxDeletions
Afterwards, a check is done for  (loopCounter != maxDeletions) to determine if the processing is finished.
If `loopCounter == maxDeletions` then the conclusion is that it isnt finished yet.
However, there is the edgecase that the processing might just be finished at the same time as _loopCounter == maxDeletions.
You can see this the best if you assume maxDeletions==1, in that case it will never draw the conclusion it is finished.
Of course having maxDeletions==1 is very unlikely in practice.
Recommend using a different way to determine that the processing is done. This could save some gas.
Note: the additional check also costs gas, so you have to verify the end result.
Perhaps in setDeletionLimit, doublecheck that _deletionLimit > 1.
Splidge (Reality Cards) confirmed and disagreed with severity:
Splidge (Reality Cards) commented:
0xean (judge) commented:
Splidge (Reality Cards) patched:
