The FairSide contracts use DappHubs DSMath safe arithmetic library that provides overflow/underflow protection. But, the safe DSMath functions are not used in many places, especially in the FSD mint/burn functions.
While there do not appear to be any obvious integer overflows/underflows in the conditions envisioned, there could be exceptional paths where overflows/underflows may be triggered, leading to minting/burning an unexpected number of tokens.
Recommend using DSMath add/sub functions instead of +/- in all places.
fairside-core (FairSide) acknowledged:
cemozerr (Judge) commented:
