Submitted by cccz, also found by danb, and WatchPug
Using the mintCollateralToken() function of CollateralToken, an address with COLLATERALMINTERROLE can mint an arbitrary amount of tokens.
If the private key of the deployer or an address with the COLLATERALMINTERROLE is compromised, the attacker will be able to mint an unlimited amount of collateral tokens.
We believe this is unnecessary and poses a serious centralization risk.
CollateralToken.sol#L101-L117
CollateralToken.sol#L138-L160
Consider removing the COLLATERALMINTERROLE, make the CollateralToken only mintable by the owner, and make the Controller contract to be the owner and therefore the only minter.
0xca11 (Rolla) confirmed
alcueca (judge) commented:
0xca11 (Rolla) resolved and commented:
