Submitted by IllIllI
Note: this finding was reported via the winning Automated Findings report. It was declared out of scope for the audit, but is being included here for completeness.
Not all IERC20 implementations revert() when theres a failure in approve(). The function signature has a boolean return value and they indicate errors that way instead. By not checking the return value, operations that should have marked as failed, may potentially go through without actually approving anything.
There are 5 instances of this issue:
GitHub: 134
GitHub: 150, 169, 173
GitHub: 411
psytama (Dopex) disputed
Alex the Entreprenerd (Judge) commented
