Submitted by rayn
StrategyPUSDConvex.sol#L234
As specified in Convex BaseRewardPool.sol and VirtualRewardPool.sol, the function signature of earned is earned(address). However, balanceOfJPEG did not pass any arguments to earned, which would cause balanceOfJPEG to always revert.
This bug will propagate through Controller and YVault until finally reaching the source of the call in YVaultLPFarming ._computeUpdate, and render the entire farming contract unuseable.
Both BaseRewardPool.earned and VirtualBalanceRewardPool.earned takes an address as argument
But balanceOfJPEG does not pass any address to extraReward.earned, causing the entire function to revert when called
vim, ganache-cli
Pass address(this) as argument of earned.
Notice how we modify the fetching of reward. This is reported in a separate bug report, but for completeness, the entire fix is shown in both report entries.
spaghettieth (JPEGd) confirmed, but disagreed with High severity
spaghettieth (JPEGd) resolved and commented:
LSDan (judge) commented:
