The Vault::rebalance() function rounds-down the sharesToMint against the protocols favour. It ought to be rounded-up to avoid loss of funds for the protocol.
Loss of funds for the protocol.
Round up in favour of the protocol. A library like solmate can be used which has mulDivUp:
hvasconcelos (BakerFi) confirmed
0xleastwood (judge) decreased severity to Low/Non-Critical and commented:
ickas (BakerFi) commented:
