Submitted by 0xBeirao
https://github.com/code-423n4/2023-01-popcorn/blob/d95fc31449c260901811196d617366d6352258cd/src/vault/Vault.sol#L594-L613
https://github.com/code-423n4/2023-01-popcorn/blob/d95fc31449c260901811196d617366d6352258cd/src/vault/adapter/abstracts/AdapterBase.sol#L162
Changing the adapter (that uses a strategy) of an already credited vault can result in a loss of user funds.
Scenario:
Issue scenario 1 : the **harvest()** function is in cooldown.
Issue scenario 2 : the **harvest()** function revert.
In both cases, the **harvest()** function will not execute. The adapter will change without harvesting from the Strategy causing the loss of unclaimed rewards.
Change the harvest() function from :
to :
RedVeil (Popcorn) confirmed, but disagreed with severity 
LSDan (judge) decreased severity to Medium 
